Hi, On Wed, Apr 24, 2019 at 9:28 AM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > The Mali GPU of the rk3288 can be used as cooling device, add > a #cooling-cells entry for it. > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > --- > arch/arm/boot/dts/rk3288.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index ca7d52daa8fb..767e62908a6e 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi > @@ -1275,6 +1275,7 @@ > interrupt-names = "job", "mmu", "gpu"; > clocks = <&cru ACLK_GPU>; > operating-points-v2 = <&gpu_opp_table>; > + #cooling-cells = <2>; /* min followed by max */ > power-domains = <&power RK3288_PD_GPU>; > status = "disabled"; > }; Seems like a good idea to me. Presumably we should also add this to the bindings? Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> -Doug