On Wed, May 15, 2019 at 03:26:14PM +0530, Amit Kucheria wrote: > On Mon, May 13, 2019 at 3:19 PM Sudeep Holla <sudeep.holla@xxxxxxx> wrote: > > > > On Fri, May 10, 2019 at 11:58:40PM +0530, Amit Kucheria wrote: > > > On Fri, May 10, 2019 at 2:54 PM Sudeep Holla <sudeep.holla@xxxxxxx> wrote: > > > > > > > > [...] > > > > > > > > > > Yes entry-method="psci" is required as per DT binding but not checked > > > > in code on arm64. We have CPU ops with idle enabled only for "psci", so > > > > there's not need to check. > > > > > > I don't see it being checked on arm32 either. > > > > > > > arm_cpuidle_get_ops in arch/arm/kernel/cpuidle.c checks the method, has > > to match "psci" for drivers/firmware/psci.c to work on arm32 > > That is a check for the enable-method, not entry-method. > > We don't check for entry-method anywhere, AFAICT. > Ah, you right. My eyes can't distinguish between entry-method and enable-method anymore :( -- Regards, Sudeep
