On Wed, 15 May 2019, masonccyang@xxxxxxxxxxx wrote: > Hi Jones, > > > > > + > > > +struct rpc_spi { > > > + struct rpc_mfd *mfd; > > > > The term MFD isn't a real thing. What you're obtaining below is > > driver data and is normally articulated as 'ddata' in drivers. > > yes, it's just imply that data is from MFD. > > Should I rename "mfd" ? Yes please. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog