> -----Original Message----- > From: Yinbo Zhu > Sent: 2019年5月5日 14:07 > To: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Leo Li <leoyang.li@xxxxxxx>; Xiaobo > Xie <xiaobo.xie@xxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; Y.b. Lu > <yangbo.lu@xxxxxxx>; Jiafei Pan <jiafei.pan@xxxxxxx>; Ashish Kumar > <ashish.kumar@xxxxxxx> > Subject: RE: [EXT] Re: [PATCH v1] arm64: ls1028: dtsi: Add esdhc node in dtsi > > > > > -----Original Message----- > > From: Rob Herring [mailto:robh+dt@xxxxxxxxxx] > > Sent: 2019年5月2日 1:50 > > To: Yinbo Zhu <yinbo.zhu@xxxxxxx> > > Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Leo Li <leoyang.li@xxxxxxx>; > > Xiaobo Xie <xiaobo.xie@xxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > > linux-kernel@xxxxxxxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; Y.b. Lu > > <yangbo.lu@xxxxxxx>; Jiafei Pan <jiafei.pan@xxxxxxx>; Ashish Kumar > > <ashish.kumar@xxxxxxx> > > Subject: [EXT] Re: [PATCH v1] arm64: ls1028: dtsi: Add esdhc node in > > dtsi > > > > Caution: EXT Email > > > > On Tue, Apr 23, 2019 at 6:42 AM Yinbo Zhu <yinbo.zhu@xxxxxxx> wrote: > > > > > > From: Ashish Kumar <Ashish.Kumar@xxxxxxx> > > > > > > This patch is to add esdhc node and enable SD UHS-I, eMMC HS200 for > > > ls1028ardb/ls1028aqds board. > > > > > > Signed-off-by: Ashish Kumar <Ashish.Kumar@xxxxxxx> > > > Signed-off-by: Yangbo Lu <yangbo.lu@xxxxxxx> > > > Signed-off-by: Yinbo Zhu <yinbo.zhu@xxxxxxx> > > > --- > > > .../boot/dts/freescale/fsl-ls1028a-qds.dts | 8 ++++++ > > > .../boot/dts/freescale/fsl-ls1028a-rdb.dts | 13 +++++++++ > > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 27 > > > +++++++++++++++++++ > > > 3 files changed, 48 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > > > index 14c79f4691ea..180e5d2a00d1 100644 > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > > > @@ -42,6 +42,14 @@ > > > status = "okay"; > > > }; > > > > > > +&esdhc { > > > + status = "okay"; > > > +}; > > > + > > > +&esdhc1 { > > > + status = "okay"; > > > +}; > > > + > > > &i2c0 { > > > status = "okay"; > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > > > index f86b054a74ae..1bfaf4294db4 100644 > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > > > @@ -30,6 +30,19 @@ > > > }; > > > }; > > > > > > +&esdhc { > > > + status = "okay"; > > > + sd-uhs-sdr104; > > > + sd-uhs-sdr50; > > > + sd-uhs-sdr25; > > > + sd-uhs-sdr12; > > > + }; > > > + > > > +&esdhc1 { > > > + status = "okay"; > > > + mmc-hs200-1_8v; > > > + }; > > > + > > > &i2c0 { > > > status = "okay"; > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > index 2896bbcfa3bb..d13cd3fb455b 100644 > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > @@ -274,6 +274,33 @@ > > > status = "disabled"; > > > }; > > > > > > + esdhc: esdhc@2140000 { > > > > mmc@... > > > > > + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc"; > > > + reg = <0x0 0x2140000 0x0 0x10000>; > > > + interrupts = <0 28 0x4>; /* Level high type */ > > > + clock-frequency = <0>; > > > > Filled in by bootloader? If so, add a comment. > Hi rob, > Filled in by kernel, please you note. > > Regards, > Yinbo. Hi rob, I'm sorry, It is fixed up by bootloader actually. And I will add a commont. yinbo > > > + clocks = <&clockgen 2 1>; > > > + voltage-ranges = <1800 1800 3300 3300>; > > > + sdhci,auto-cmd12; > > > + little-endian; > > > + bus-width = <4>; > > > + status = "disabled"; > > > + }; > > > + > > > + esdhc1: esdhc@2150000 { > > > > mmc@... > > > > > + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc"; > > > + reg = <0x0 0x2150000 0x0 0x10000>; > > > + interrupts = <0 63 0x4>; /* Level high type */ > > > + clock-frequency = <0>; > > > + clocks = <&clockgen 2 1>; > > > + voltage-ranges = <1800 1800 3300 3300>; > > > + sdhci,auto-cmd12; > > > + broken-cd; > > > + little-endian; > > > + bus-width = <4>; > > > + status = "disabled"; > > > + }; > > > + > > > sata: sata@3200000 { > > > compatible = "fsl,ls1028a-ahci"; > > > reg = <0x0 0x3200000 0x0 0x10000>, > > > -- > > > 2.17.1 > > >