On Tue, May 14, 2019 at 08:53:18AM -0500, Zhi Li wrote: > On Tue, May 7, 2019 at 2:30 PM Andrey Smirnov <andrew.smirnov@xxxxxxxxx> wrote: > > > > On Wed, May 1, 2019 at 11:43 AM Frank Li <frank.li@xxxxxxx> wrote: > > > > > > Add ddr performance monitor support for iMX8QXP > > > > > > There are 4 counters for ddr perfomance events. > > > counter 0 is dedicated for cycles. > > > you choose any up to 3 no cycles events. > > > > > > for example: > > > > > > perf stat -a -e imx8_ddr0/read-cycles/,imx8_ddr0/write-cycles/,imx8_ddr0/precharge/ ls > > > perf stat -a -e imx8_ddr0/cycles/,imx8_ddr0/read-access/,imx8_ddr0/write-access/ ls > > > > > > Support below events. > > > > > > imx8_ddr0/activate/ [Kernel PMU event] > > > imx8_ddr0/axid-read/ [Kernel PMU event] > > > imx8_ddr0/axid-write/ [Kernel PMU event] > > > imx8_ddr0/cycles/ [Kernel PMU event] > > > imx8_ddr0/hp-read-credit-cnt/ [Kernel PMU event] > > > imx8_ddr0/hp-read/ [Kernel PMU event] > > > imx8_ddr0/hp-req-nodcredit/ [Kernel PMU event] > > > imx8_ddr0/hp-xact-credit/ [Kernel PMU event] > > > imx8_ddr0/load-mode/ [Kernel PMU event] > > > imx8_ddr0/lp-read-credit-cnt/ [Kernel PMU event] > > > imx8_ddr0/lp-req-nocredit/ [Kernel PMU event] > > > imx8_ddr0/lp-xact-credit/ [Kernel PMU event] > > > imx8_ddr0/mwr/ [Kernel PMU event] > > > imx8_ddr0/precharge/ [Kernel PMU event] > > > imx8_ddr0/raw-hazard/ [Kernel PMU event] > > > imx8_ddr0/read-access/ [Kernel PMU event] > > > imx8_ddr0/read-activate/ [Kernel PMU event] > > > imx8_ddr0/read-command/ [Kernel PMU event] > > > imx8_ddr0/read-cycles/ [Kernel PMU event] > > > imx8_ddr0/read-modify-write-command/ [Kernel PMU event] > > > imx8_ddr0/read-queue-depth/ [Kernel PMU event] > > > imx8_ddr0/read-write-transition/ [Kernel PMU event] > > > imx8_ddr0/read/ [Kernel PMU event] > > > imx8_ddr0/refresh/ [Kernel PMU event] > > > imx8_ddr0/selfresh/ [Kernel PMU event] > > > imx8_ddr0/wr-xact-credit/ [Kernel PMU event] > > > imx8_ddr0/write-access/ [Kernel PMU event] > > > imx8_ddr0/write-command/ [Kernel PMU event] > > > imx8_ddr0/write-credit-cnt/ [Kernel PMU event] > > > imx8_ddr0/write-cycles/ [Kernel PMU event] > > > imx8_ddr0/write-queue-depth/ [Kernel PMU event] > > > imx8_ddr0/write/ > > > > > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > > > > Don't really have anything to suggest, that I already haven't. LGTM, so: > > > > Reviewed-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > > > Will Deacon: > Is it okay to pick up these patches? Andrey always acked. It's the merge window at the moment, so it's too late for 5.2. I'll have a look at these in a couple of weeks as candidates for 5.3. Thanks, Will