On Fri, May 10, 2019 at 06:53:25PM +0000, Sowjanya Komatineni wrote: > > On Mon, Apr 29, 2019 at 10:02:46PM +0000, Sowjanya Komatineni wrote: To reiterate: > > Please fix your mail client to word wrap within paragraphs at > > something substantially less than 80 columns. Doing this makes your > > messages much easier to read and reply to. > Any concerns for using set_cs API from SPI core as it already does direct gpio based cs using > Descriptors? Yes, that is precisely what I'm telling you not to do. That function doesn't do enough to make it worth exporting and the code that uses it assumes it's managing the chip select entirely, adding a single other use will make things fragile as it will mean that there's a chance someone will change what the core is doing without taking into account the different things that the Tegra code is doing. Either let the core handle chip select entirely or open code it.
Attachment:
signature.asc
Description: PGP signature
