On 09-05-19, 09:03, Leonard Crestez wrote: > On 5/8/2019 6:54 AM, Viresh Kumar wrote: > > On 07-05-19, 13:52, Leonard Crestez wrote: > > >> +config ARM_IMX_CPUFREQ_DT > >> + tristate "Freescale i.MX8M cpufreq support" > >> + depends on ARCH_MXC && CPUFREQ_DT > >> + default m if ARCH_MXC && CPUFREQ_DT > > > > As I said in the previous version, the if block above is redundant and > > not required. > > Sorry, I misread and thought you were referring to () rather than what's > inside. > > Is "default m" otherwise OK? It's a reasonable implication of ARCH_MXC I think it would be better to keep it disabled by default and so removing the line all together would be a good option. -- viresh