On 2019/5/1 17:29, Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx> wrote: > -----Original Message----- > From: Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx> > Sent: 2019年5月1日 17:29 > To: devicetree@xxxxxxxxxxxxxxx; Qiang Zhao <qiang.zhao@xxxxxxx>; Leo Li > <leoyang.li@xxxxxxx> > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; Rob Herring <robh+dt@xxxxxxxxxx>; Scott Wood > <oss@xxxxxxxxxxxx>; Christophe Leroy <christophe.leroy@xxxxxx>; Mark > Rutland <mark.rutland@xxxxxxx>; Rasmus Villemoes > <Rasmus.Villemoes@xxxxxxxxx> > Subject: [PATCH v2 1/6] soc/fsl/qe: qe.c: drop useless static qualifier > > The local variable snum_init has no reason to have static storage duration. > > Reviewed-by: Christophe Leroy <christophe.leroy@xxxxxx> > Signed-off-by: Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx> Reviewed-by: Qiang Zhao <qiang.zhao@xxxxxxx> > --- > drivers/soc/fsl/qe/qe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c index > 612d9c551be5..855373deb746 100644 > --- a/drivers/soc/fsl/qe/qe.c > +++ b/drivers/soc/fsl/qe/qe.c > @@ -306,7 +306,7 @@ static void qe_snums_init(void) > 0x28, 0x29, 0x38, 0x39, 0x48, 0x49, 0x58, 0x59, > 0x68, 0x69, 0x78, 0x79, 0x80, 0x81, > }; > - static const u8 *snum_init; > + const u8 *snum_init; > > qe_num_of_snum = qe_get_num_of_snums(); > > -- > 2.20.1 Best Regards Qiang Zhao
