Re: [PATCH V7 RESEND 04/10] can: mcp25xxfd: Add Microchip mcp25xxfd CAN FD driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marc!

> On 08.05.2019, at 15:12, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
>> static int mcp25xxfd_can_switch_mode_no_wait(struct mcp25xxfd_priv *priv,
>> 					     u32 *reg, int mode)
>> {
>> 	u32 dummy;
>> 	int ret;
>> 
>> 	/* get the current mode/register - if reg is NULL
>> 	 * when the can controller is not setup yet
>> 	 * typically by calling mcp25xxfd_can_sleep_mode
>> 	 * (this only happens during initialization phase)
>> 	 */
>> 	if (reg) {
>> 		if (!reg) {
> 
> This looks wrong.

should be:
>> 		if (!*reg) {

Fixed that - thanks!

Thanks,
	Martin 



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux