> On Fri, Apr 26, 2019 at 08:05:51AM +0000, Robin Gong wrote: > > ERR009165 fixed from i.mx6ul, add it to show the errata fixed. > > > > Signed-off-by: Robin Gong <yibin.gong@xxxxxxx> > > --- > > Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > > b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > > index 2d32641..32c4263d 100644 > > --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > > +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > > @@ -10,6 +10,8 @@ Required properties: > > - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35 > > - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51 > > - "fsl,imx53-ecspi" for SPI compatible with the one integrated on > > i.MX53 and later Soc > > + - "fsl,imx6ul-ecspi" ERR009165 fixed on i.MX6UL and later Soc > > + > > + (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fw > > + > ww.nxp.com%2Fdocs%2Fen%2Ferrata%2FIMX6DQCE.pdf&data=02%7C01 > %7Cyi > > + > bin.gong%40nxp.com%7Cc36708a8219843ffe1d308d6cecbc512%7C686ea1d > 3bc2b > > + > 4c6fa92cd99c5c301635%7C0%7C1%7C636923771907346428&sdata=9e > 8c8GK2 > > + hSE90rzyArm8elog9dwNqn4Jeoeff79XwI4%3D&reserved=0) > > I wouldn't mention this errata in the binding documentation. Just state that > fsl,imx6ul-ecspi is designed to be used on i.MX6UL. And that it might also be > used on later SoCs as a "fallback compatible" is a detail that is so common that Eh...Maybe add one flag member in 'struct spi_imx_devtype_data' to state errata fixed is better? > I would expect it not being worth mentioning. So for me it would also be OK to > drop "fsl,imx53-ecspi" from the list as this is only used like: > > compatible = "fsl,imx53-ecspi", "fsl,imx51-ecspi"; > > (But note that I have no authority here.) > > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König > | > Industrial Linux Solutions | > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe > ngutronix.de%2F&data=02%7C01%7Cyibin.gong%40nxp.com%7Cc36708 > a8219843ffe1d308d6cecbc512%7C686ea1d3bc2b4c6fa92cd99c5c301635%7 > C0%7C1%7C636923771907346428&sdata=McF9ueExCPpCq5Nxa6iJ9h53 > 9d9fO4DIW2IaS90ZdpQ%3D&reserved=0 |
