On Sat 2019-05-04 14:28:24, list@xxxxxxxxxxxxx wrote:
> From: Christian Mauderer <oss@xxxxxxxxxxxxx>
>
> This patch adds the binding documentation for the LED controller found
> in Ubiquity airCube ISP devices.
>
> Signed-off-by: Christian Mauderer <oss@xxxxxxxxxxxxx>
> ---
>
> I tested the patches with a 4.14 and a 4.19 kernel on the current OpenWRT.
> Although I didn't get the kernel running due to file system problems they build
> fine with a 5.1-rc7.
>
> I shortly described the protocol of the controller in a comment in the driver
> file in the second patch.
>
> Checkpatch gives the following warning for both patches:
>
> WARNING: added, moved or deleted file(s), does MAINTAINERS need
> updating?
Ignore that :-).
> diff --git a/Documentation/devicetree/bindings/leds/leds-ubnt-spi.txt b/Documentation/devicetree/bindings/leds/leds-ubnt-spi.txt
> new file mode 100644
> index 000000000000..ab1478cdc139
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-ubnt-spi.txt
> @@ -0,0 +1,49 @@
> +Binding for the controller based LED found in Ubiquity airCube ISP and most
> +likely some other Ubiquity devices.
It would be good to know what chip it is.. and name the binding
accordingly.
Alternatively, call its led-spi-byte, or something, as it is really
trivial protocol. Maybe other chips will have same interface?
> +Example for the airCube ISP (with SPI controller matching that device):
> +
> +led_spi {
> + compatible = "spi-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gpio-sck = <&gpio 3 GPIO_ACTIVE_HIGH>;
> + gpio-mosi = <&gpio 2 GPIO_ACTIVE_HIGH>;
> + cs-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;
> + num-chipselects = <1>;
> +
> + led_ubnt@0 {
> + compatible = "ubnt,spi-led";
> + reg = <0>;
> + spi-max-frequency = <100000>;
> +
> + led {
> + label = "system";
> + /* keep the LED slightly on to show powered device */
> + ubnt-spi,off_bright = /bits/ 8 <4>;
> + };
> + };
> +};
Otherwise looks good to me,
Acked-by: Pavel Machek <pavel@xxxxxx>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
