On Monday, April 07, 2014 5:39 PM, Lucas Stach wrote: > Am Freitag, den 04.04.2014, 11:05 -0600 schrieb Bjorn Helgaas: > > On Fri, Apr 04, 2014 at 11:03:41AM -0600, Bjorn Helgaas wrote: > > > On Wed, Mar 05, 2014 at 11:42:19AM -0700, Jason Gunthorpe wrote: > > > > On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote: > > > > > - return pp->irq; > > > > > + irq = of_irq_parse_and_map_pci(dev, slot, pin); > > > > > + if (!irq) > > > > > + irq = pp->irq; > > > > > > > > In light of the two bugs that Tim found, it might be wise to throw a > > > > 'dev_warn(FW_BUG "Missing DT interrupt mapping")' in the fall back > > > > path, so it doesn't continue to silently cover up errors on the OF/DT > > > > side.. > > > > > > This sounds like a reasonable thing to do, but I didn't see a response to > > > this comment. Should I merge it as-is, or do you want to add the message? > > > > Oh, and I suppose the same question applies to the other host drivers in > > this series (tegra, rcar)? > > Please apply as-is. of_irq_parse_and_map_pci() already prints an error > message if it isn't able to establish the mapping, thus right before we > fall into the fallback path. So any the warning would be redundant. +1 I agree with Lucas Stach's opinion. of_irq_parse_and_map_pci() already prints an error as below. So, additional warning message of host controller looks superfluous. ret = of_irq_parse_pci(dev, &oirq); if (ret) { dev_err(&dev->dev, "of_irq_parse_pci() failed with rc=%d\n", ret); return 0; /* Proper return code 0 == NO_IRQ */ Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html