> -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Thursday 2 May 2019 18:24 > To: Dragan Cvetic <draganc@xxxxxxxxxx> > Cc: arnd@xxxxxxxx; Michal Simek <michals@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; > mark.rutland@xxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Derek Kiernan <dkiernan@xxxxxxxxxx> > Subject: Re: [PATCH V3 04/12] misc: xilinx_sdfec: Add open, close and ioctl > > On Sat, Apr 27, 2019 at 11:04:58PM +0100, Dragan Cvetic wrote: > > Add char device interface per DT node present and support > > file operations: > > - open(), > > - close(), > > - unlocked_ioctl(), > > - compat_ioctl(). > > Why do you need compat_ioctl() at all? Any "new" driver should never > need it. Just create your structures properly. This was a comment from Arnd, see https://lkml.org/lkml/2019/3/19/377. Please advise. > > thanks, > > greg k-h
