On Tue, Apr 30, 2019 at 03:32:32PM +0200, Torsten Duwe wrote: > On Mon, Feb 18, 2019 at 11:24:42AM +0100, Maxime Ripard wrote: > > On Sat, Feb 16, 2019 at 09:47:13PM +0100, Harald Geyer wrote: > > > > > > > Would you care to submit a patch version without that GPIO handled? > > > > I think it's very useful and has the potential to be agreed upon. > > > > > > That would enable audio from the internal speakers but select debug > > > output on the HP jack by default. I would be okay with that, despite > > > still thinking that audio on the head phones should be the default. > > > > > > Maxime and Wens are the maintainers, so it's their call in the end. > > > > At this point, I'm not really convinced by the solution in that patch, > > but I don't have really good ideas either. I think it would be good to > > discuss this with Mark and Linus Walleij, they will probably have way > > better solutions than what I can come up with. > > Once more my plead to *please* apply the unchallenged parts of this patch! > > For reference: > https://patchwork.kernel.org/patch/10792589/ > > > Just leave out the line > > + hpvcc-supply = <®_eldo1>; /* TODO: Use only one of these */ > (as clarified by ChenYu) > > and the > > @@ -131,6 +151,14 @@ > status = "okay"; > }; > > +&r_pio { > + r_debug_select_pin: debug-select { > [...] > > hunk, which the discussion was about. The patch is of good value > even without it. > > IMHO it's a shame this didn't make it into 5.1 > > Acked-by: Torsten Duwe <duwe@xxxxxxx> Please resend that patch Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
