On Tue, Apr 30, 2019 at 04:51:02PM +0800, Henry Chen wrote: > Add interconnect provider dt-bindings for MT8183. > > Signed-off-by: Henry Chen <henryc.chen@xxxxxxxxxxxx> > --- > .../bindings/interconnect/mtk,mt8183.txt | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interconnect/mtk,mt8183.txt > > diff --git a/Documentation/devicetree/bindings/interconnect/mtk,mt8183.txt b/Documentation/devicetree/bindings/interconnect/mtk,mt8183.txt > new file mode 100644 > index 0000000..1cf1841 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interconnect/mtk,mt8183.txt > @@ -0,0 +1,24 @@ > +Mediatek MT8183 interconnect binding This should be part of the dvfsrc binding. > + > +MT8183 interconnect providers support dram bandwidth requirements. The provider > +is able to communicate with the DVFSRC and send the dram bandwidth to it. > +Provider nodes must reside within an DVFSRC device node. > + > +Required properties : > +- compatible : shall contain only one of the following: > + "mediatek,mt8183-emi-icc" > +- #interconnect-cells : should contain 1 > + > +Examples: > + > +dvfsrc@10012000 { > + compatible = "mediatek,mt8183-dvfsrc"; > + reg = <0 0x10012000 0 0x1000>; > + clocks = <&infracfg CLK_INFRA_DVFSRC>; > + clock-names = "dvfsrc"; > + ddr_emi: interconnect { > + compatible = "mediatek,mt8183-emi-icc"; > + #interconnect-cells = <1>; No need for a child node here. Just move #interconnect-cells to the parent. Rob