Rob, On Fri, Apr 26, 2019 at 01:45:59PM -0500, Rob Herring wrote: > On Mon, Apr 15, 2019 at 05:29:48PM -0400, Gaël PORTAY wrote: > > diff --git a/include/dt-bindings/power/rk3399-dram.h b/include/dt-bindings/power/rk3399-dram.h > > new file mode 100644 > > index 000000000000..4b3d4a79923b > > --- /dev/null > > +++ b/include/dt-bindings/power/rk3399-dram.h > > @@ -0,0 +1,73 @@ > > +/* SPDX-License-Identifier: (GPL-2.0+ OR X11) */ > > +/* > > + * Copyright (c) 2016-2018, Fuzhou Rockchip Electronics Co., Ltd > > + * > > + * Author: Lin Huang <hl@xxxxxxxxxxxxxx> > > + */ > > + > > +#ifndef _DTS_DRAM_ROCKCHIP_RK3399_H > > +#define _DTS_DRAM_ROCKCHIP_RK3399_H > > + > > +#define DDR3_DS_34ohm 34 > > +#define DDR3_DS_40ohm 40 > > + > > +#define DDR3_ODT_DIS 0 > > +#define DDR3_ODT_40ohm 40 > > +#define DDR3_ODT_60ohm 60 > > +#define DDR3_ODT_120ohm 120 > > I don't think these defines add much value given the value is in the > define itself. > > Do these get used by the driver? If not, then the header can go with the > dts file. But I'd just get rid of the header. > > Rob > Indeed, I will remove that header and update the documentation file. Regards, Gaël
