On Tue, Apr 2, 2019 at 6:46 PM Chris Packham <Chris.Packham@xxxxxxxxxxxxxxxxxxx> wrote: > > Hi Boris, > > I've just come across the commit from this patch. > > On 19/10/18 8:49 PM, Boris Brezillon wrote: > > There's no real reason to have two separate driver for the DT and pdata > > case. Just do what we do everywhere else and handle DT and pdata > > parsing in the same driver. > > > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx> > > Reviewed-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> > > --- > > Changes in v2: > > - Add Ricardo's R-b > > - Fix 2 checks (reported by Ricardo) > > --- > > drivers/mtd/maps/Kconfig | 4 +- > > drivers/mtd/maps/Makefile | 7 +- > > drivers/mtd/maps/physmap-core.c | 261 +++++++++++++++++++++++--- > > drivers/mtd/maps/physmap_of_core.c | 368 ------------------------------------- > > 4 files changed, 240 insertions(+), 400 deletions(-) > > delete mode 100644 drivers/mtd/maps/physmap_of_core.c > > > > diff --git a/drivers/mtd/maps/Kconfig b/drivers/mtd/maps/Kconfig > > index afb36bff13a7..5bffebacce86 100644 > > --- a/drivers/mtd/maps/Kconfig > > +++ b/drivers/mtd/maps/Kconfig > > @@ -66,8 +66,8 @@ config MTD_PHYSMAP_BANKWIDTH > > used internally by the CFI drivers. > > > > config MTD_PHYSMAP_OF > > - tristate "Memory device in physical memory map based on OF description" > > - depends on OF && (MTD_CFI || MTD_JEDECPROBE || MTD_ROM || MTD_RAM) > > + bool "Memory device in physical memory map based on OF description" > > + depends on OF && MTD_PHYSMAP > > Previously we could select MTD_PHYSMAP_OF if MTD_RAM was defined. After > this change we can't select this because MTD_PHYSMAP does not have > MTD_RAM as dependency. > > I'm just in the process of porting the latest kernel to a platform with > parallel SRAM and NAND via a dedicated controller. I haven't got to a > point where the platform is booting but I suspect I'll loose my SRAM. Another minor issue is that previously the MTD_PHYSMAP_OF can be selected separately, but now it cannot be selected without the MTD_PHYSMAP. This may break existing defconfigs. Probably it will be better to select MTD_PHYSMAP automatically when MTD_PHYSMAP_OF is selected? Regards, Leo
