Hi Biju, On Tue, Apr 16, 2019 at 5:38 PM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > The r8a774a1 soc has 5 VSP instances similar to r8a7796. > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > @@ -1877,6 +1877,61 @@ > iommus = <&ipmmu_vc0 19>; > }; > > + vspb: vsp@fe960000 { > + compatible = "renesas,vsp2"; > + reg = <0 0xfe960000 0 0x8000>; > + interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 626>; > + power-domains = <&sysc R8A774A1_PD_A3VC>; I have my doubts about vspb (and fcpvb0) being part of the A3VC power domain (also on R-Car M3-W). > + resets = <&cpg 626>; > + > + renesas,fcp = <&fcpvb0>; > + }; Apart from that: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds