Hi Paweł, Paweł Chmiel <pawel.mikolaj.chmiel@xxxxxxxxx> wrote on Fri, 26 Apr 2019 18:42:20 +0200: > From: Tomasz Figa <tomasz.figa@xxxxxxxxx> > > Before this patch, the order of memory resources requested by the driver > was controller base as first and OneNAND chip base as second for > S3C64xx/S5PC100 variant and the opposite for S5PC110/S5PV210 variant. > > To make this more consistent, this patch swaps the order of resources > for the latter and updates platform code accordingly. As a nice side > effect there is a slight reduction in line count of probe function. > > Signed-off-by: Tomasz Figa <tomasz.figa@xxxxxxxxx> > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@xxxxxxxxx> Thanks for the patch but it looks like you also are renaming fields in the main onenand structure. Maybe it is worth doing it in a preliminary patch. Thanks, Miquèl