Hi Linus, On Tue, Apr 23, 2019 at 1:13 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > On Thu, Apr 18, 2019 at 2:48 PM Guillaume La Roque > <glaroque@xxxxxxxxxxxx> wrote: > > > The purpose of this patchset is to add drive-strength support in meson pinconf > > driver. This is a new feature that was added on the g12a. It is critical for us > > to support this since many functions are failing with default pad drive-strength. > > > > The value achievable by the SoC are 0.5mA, 2.5mA, 3mA and 4mA and the DT property > > 'drive-strength' is expressed in mA. > > So this patch add another generic property "drive-strength-uA". The change to do so > > would be minimal and could be benefit to other platforms later on. > > > > Cheers > > Guillaume > > This needs to be reviewed by Martin Blumenstigl, Martin can you have a look > at this patch set? If you don't have the patches I think Guillaume can > resend them. thank you for the reminder - I just sent my feedback. can you please also have a look at patch 4/4? there are two cases where I'm not sure what the best practice of the pinctrl subsystem is Regards Martin