On Fri, Apr 26, 2019 at 02:47:13PM +0800, Chunfeng Yun wrote: > It's used to support dual role switch via GPIO when use Type-B > receptacle, typically the USB ID pin is connected to an input > GPIO pin > > Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx> > --- > v4 no changes > > v3 changes: > 1. treat type-B connector as a virtual device, but not child device of > USB controller's > > v2 changes: > 1. new patch to make binding clear suggested by Hans > --- > .../bindings/usb/typeb-conn-gpio.txt | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/typeb-conn-gpio.txt > > diff --git a/Documentation/devicetree/bindings/usb/typeb-conn-gpio.txt b/Documentation/devicetree/bindings/usb/typeb-conn-gpio.txt > new file mode 100644 > index 000000000000..d2e1c4e01b6d > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/typeb-conn-gpio.txt > @@ -0,0 +1,49 @@ > +USB Type-B GPIO Connector > + > +This is a virtual device used to switch dual role mode from the USB ID pin > +connected to an input GPIO pin. > + > +Required properties: > +- compatible : Should be "linux,typeb-conn-gpio" There's no need for this virtual node. The USB host or device driver can instantiate a connector driver by walking the OF graph to the connector and creating a device. > + > +Sub-nodes: > +- connector : should be present. > + - compatible : should be "usb-b-connector". > + - id-gpios, vbus-gpios : either one of them must be present, > + and both can be present as well. > + - vbus-supply : can be present if needed when supports dual role mode. > + see connector/usb-connector.txt > + > +- port : should be present. > + see graph.txt > + > +Example: > + > +rsw_iddig: role_sw_iddig { > + compatible = "linux,typeb-conn-gpio"; > + status = "okay"; > + > + connector { > + compatible = "usb-b-connector"; > + label = "micro-USB"; > + type = "micro"; > + id-gpios = <&pio 12 GPIO_ACTIVE_HIGH>; > + vbus-supply = <&usb_p0_vbus>; > + }; > + > + port { Humm, same mistake as Hikey patches... This goes under the connector node as defined in the connector binding. > + bconn_ep: endpoint@0 { > + remote-endpoint = <&usb_role_sw>; > + }; > + }; > +}; > + > +&mtu3 { > + status = "okay"; > + > + port { > + usb_role_sw: endpoint@0 { > + remote-endpoint = <&bconn_ep>; > + }; > + }; > +}; > -- > 2.21.0 >