On Fri, 26 Apr 2019, Rob Herring wrote: > On Fri, Apr 12, 2019 at 9:01 PM Paul Walmsley <paul.walmsley@xxxxxxxxxx> wrote: > > > > Add DT binding documentation for the Linux driver for the SiFive > > asynchronous serial IP block. > > > > This revision incorporates changes based on feedback from Rob > > Herring <robh@xxxxxxxxxx>. > > > > Signed-off-by: Paul Walmsley <paul.walmsley@xxxxxxxxxx> > > Signed-off-by: Paul Walmsley <paul@xxxxxxxxx> > > Cc: linux-serial@xxxxxxxxxxxxxxx > > Cc: devicetree@xxxxxxxxxxxxxxx > > Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx > > Cc: linux-kernel@xxxxxxxxxxxxxxx > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Cc: Mark Rutland <mark.rutland@xxxxxxx> > > Cc: Palmer Dabbelt <palmer@xxxxxxxxxx> > > --- > > .../bindings/serial/sifive-serial.txt | 33 +++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/serial/sifive-serial.txt > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> Thanks Rob. > However, what about flow-control configuration? You'd better think now > about what the default is and overriding that. The underlying IP doesn't support it. https://github.com/sifive/riscv-linux/blob/dev/paulw/dts-v5.1-rc6-experimental/drivers/tty/serial/sifive.c#L30 - Paul