On Mon, Apr 22, 2019 at 5:45 AM Shawn Guo <shawnguo@xxxxxxxxxx> wrote: > > On Fri, Apr 19, 2019 at 08:20:39PM +0000, Daniel Baluta wrote: > > i.MX8MM has 5 SAI instances with the following base > > addresses according to RM. > > > > SAI1 base address: 3001_0000h > > SAI2 base address: 3002_0000h > > SAI3 base address: 3003_0000h > > SAI5 base address: 3005_0000h > > SAI6 base address: 3006_0000h > > > > Signed-off-by: Bai Ping <ping.bai@xxxxxxx> > > Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxx> > > --- > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 68 +++++++++++++++++++++++ > > 1 file changed, 68 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > index de3498c2dd44..e9a0b2b6063a 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > @@ -171,6 +171,74 @@ > > #size-cells = <1>; > > ranges; > > > > + sai1: sai@30010000 { > > + compatible = "fsl,imx8mq-sai", > > Should be "fsl,imx8mm-sai"? SAI IP on imx8mm is identical with the one on imx8mq. There is no need to differentiate with a compatible string. What is the common practice for such cases?