Re: [PATCH] of_net: Fix residues after of_get_nvmem_mac_address removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Petr Štetiar <ynezz@xxxxxxx>
Date: Wed, 17 Apr 2019 22:09:12 +0200

> I've discovered following discrepancy in the bindings/net/ethernet.txt
> documentation, where it states following:
> 
>  - nvmem-cells: phandle, reference to an nvmem node for the MAC address;
>  - nvmem-cell-names: string, should be "mac-address" if nvmem is to be..
> 
> which is actually misleading and confusing. There are only two ethernet
> drivers in the tree, cadence/macb and davinci which supports this
> properties.
> 
> This nvmem-cell* properties were introduced in commit 9217e566bdee
> ("of_net: Implement of_get_nvmem_mac_address helper"), but
> commit afa64a72b862 ("of: net: kill of_get_nvmem_mac_address()")
> forget to properly clean up this parts.
> 
> So this patch fixes the documentation by moving the nvmem-cell*
> properties at the appropriate places.  While at it, I've removed unused
> include as well.
> 
> Cc: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> Fixes: afa64a72b862 ("of: net: kill of_get_nvmem_mac_address()")
> Signed-off-by: Petr Štetiar <ynezz@xxxxxxx>

Applied, thanks.



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux