Re: [linux-sunxi] Re: [PATCH v3 1/7] ARM: dts: sun8i: r40: bananapi-m2-ultra: Tie GMAC regulators to the PIO

[Maxime Ripard <maxime.ripard@xxxxxxxxxxx>]

Hi,

On Thu, Apr 18, 2019 at 09:25:19AM -0300, Pablo Sebastián Greco wrote:
> El 17/4/19 a las 07:17, Maxime Ripard escribió:
> > On Wed, Apr 17, 2019 at 06:20:56AM -0300, Pablo Greco wrote:
> > > When the GMAC support was added to the bananapi-m2-ultra, regulators
> > > weren't tied to the pinctrl. Fix that.
> > >
> > > Signed-off-by: Pablo Greco <pgreco@xxxxxxxxxxxxxxxxx>
> > > ---
> > >   arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 2 ++
> > >   1 file changed, 2 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > > index c488aaa..3da3598 100644
> > > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > > @@ -201,6 +201,8 @@
> > >   &pio {
> > >   	pinctrl-names = "default";
> > >   	pinctrl-0 = <&clk_out_a_pin>;
> > > +	vcc-pa-supply = <&reg_aldo2>;
> > You should list all the regulators that are needed for all the pin
> > banks to operate properly, not just PA
> Ok, I "think" I finally understand what you mean, so according to schematics
> in https://drive.google.com/file/d/0B4PAo2nW2KfndFpmZG1OOWJ5NEU/view, it
> should look like this
> diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> index c488aaa..699579d 100644
> --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> @@ -201,6 +201,12 @@
>  &pio {
>      pinctrl-names = "default";
>      pinctrl-0 = <&clk_out_a_pin>;
> +    vcc-pa-supply = <&reg_aldo2>;
> +    vcc-pc-supply = <&reg_dcdc1>;
> +    vcc-pd-supply = <&reg_dcdc1>;
> +    vcc-pe-supply = <&reg_eldo1>;
> +    vcc-pf-supply = <&reg_dcdc1>;
> +    vcc-pg-supply = <&reg_dldo1>;
>  };

That makes sense yep

>  &reg_aldo2 {
> --
>
> I couldn't find vcc-pb, vcc-ph or vcc-pi.

The R40 doesn't have them, so there's no suprise there :)

(if you ever want to find that info again in the future, the various
vcc-p* that you need to find are in the datasheet)

> If this is ok, I'll generate a v4 based on v2, and throw v3 in the trash
> where it belongs

Sounds good, thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature