On Thu, Apr 18, 2019 at 4:54 PM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > On Thu, Apr 18, 2019 at 02:05:42PM +0530, Jagan Teki wrote: > > Add Goodix GT5663 capacitive touch controller node on > > Amarula A64-Relic board. > > > > The CTP connected to board with, > > - SDA, SCK from i2c1 > > - GPIO-LD0 as AVDD28 supply > > - PH4 gpio as interrupt pin > > - PH8 gpio as reset pin > > - X axis is inverted > > - Y axis is inverted > > > > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > > --- > > Changes for v2: > > - drop i2c1, bias-pull-up > > > > .../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > index 3575db216016..3819ce396073 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > @@ -49,6 +49,24 @@ > > bias-pull-up; > > }; > > > > +&i2c1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&i2c1_pins>; > > That's the default already Yes, and i2c1 node in sun50i-a64.dtsi is not attaching pinctrl. So I attached here.