On Wed, Apr 17, 2019 at 08:34:33AM -0500, Rob Herring wrote: > On Tue, Apr 16, 2019 at 6:54 PM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote: > > > > Add new backlight bindings for the TI LM3630A dual-string white LED. > > > > Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx> > > --- > > Rob: Since the common bindings aren't converted to the new JSON schema > > yet, I'm not sure how to do led-sources here. I would expect that we'd > > have the uint32-array on the common binding once it exists. I had to > > add it here to keep 'make dt_binding_check' happy. I left the > > description off though for that property since that'll come from common > > once its converted. > > What was the error? '$ref' shouldn't be needed for this. The tooling > has no knowledge whether there's common schema or not. So you probably > have some pattern the meta-schema doesn't like and we need to fix. Ahh, you're right... it works without the $ref. I just needed the minItems and maxItems to fix the error I originally saw. I'll wait for feedback from Dan before I send out another version with your changes. Thanks, Brian
