Paul, This mail bounced for me, but the other one on patch 1 didn't. On Wed, Apr 17, 2019 at 8:47 AM Rob Herring <robh+dt@xxxxxxxxxx> wrote: > > On Sun, Apr 14, 2019 at 3:08 PM Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote: > > > > Add macros that can be used with the ingenic,lcd-mode property in the > > devicetree node that corresponds to the ingenic-drm driver. > > DRM is a Linuxism. > > > > > Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx> > > Tested-by: Artur Rojek <contact@xxxxxxxxxxxxxx> > > --- > > > > Notes: > > v2: No change > > > > v3: s/_DRM// > > > > include/dt-bindings/display/ingenic,drm.h | 28 ++++++++++++++++++++++++++++ > > DRM is a Linuxism... > > > 1 file changed, 28 insertions(+) > > create mode 100644 include/dt-bindings/display/ingenic,drm.h > > > > diff --git a/include/dt-bindings/display/ingenic,drm.h b/include/dt-bindings/display/ingenic,drm.h > > new file mode 100644 > > index 000000000000..c749b8c346fc > > --- /dev/null > > +++ b/include/dt-bindings/display/ingenic,drm.h > > @@ -0,0 +1,28 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Ingenic JZ47xx KMS driver > > Pretty sure this file is not a KMS driver. > > > + * > > + * Copyright (C) 2019, Paul Cercueil <paul@xxxxxxxxxxxxxxx> > > + */ > > +#ifndef __INCLUDE_DT_BINDINGS_DISPLAY_INGENIC_DRM_H__ > > +#define __INCLUDE_DT_BINDINGS_DISPLAY_INGENIC_DRM_H__ > > + > > +#define JZ_LCD_GENERIC_16BIT 0 > > +#define JZ_LCD_GENERIC_18BIT 16 > > We have some generic properties for defining the bus width already. > Plus, in many cases this can be implied by the panel compatible. The > exceptions are cases such as when both the ctrlr and panel support > multiple modes. > > > + > > +#define JZ_LCD_SPECIAL_TFT_1 1 > > +#define JZ_LCD_SPECIAL_TFT_2 2 > > +#define JZ_LCD_SPECIAL_TFT_3 3 > > + > > +#define JZ_LCD_NON_INTERLACED_TV_OUT 4 > > +#define JZ_LCD_INTERLACED_TV_OUT 6 > > Wouldn't this be determined by the type of connector (composite vs. > s-video/component) > > > + > > +#define JZ_LCD_SINGLE_COLOR_STN 8 > > +#define JZ_LCD_SINGLE_MONOCHROME_STN 9 > > +#define JZ_LCD_DUAL_COLOR_STN 10 > > +#define JZ_LCD_DUAL_MONOCHROME_STN 11 > > + > > +#define JZ_LCD_8BIT_SERIAL 12 > > +#define JZ_LCD_LCM 13 > > + > > +#endif /* __INCLUDE_DT_BINDINGS_DISPLAY_INGENIC_DRM_H__ */ > > -- > > 2.11.0 > >
