Hi, I already reviewed this patch on v1[1]. [1] https://lkml.org/lkml/2019/2/11/2228 But, the second version patch doesn't include the anything about review. Please check it[1]. On 19. 3. 29. 오후 3:46, Andrew-sh.Cheng wrote: > This adds dt-binding documentation of cci devfreq > for Mediatek MT8183 SoC platform. > > Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@xxxxxxxxxxxx> > --- > .../bindings/devfreq/mt8183-cci-devfreq.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt > > diff --git a/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt b/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt > new file mode 100644 > index 0000000..e2b61cf > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt > @@ -0,0 +1,19 @@ > +* Mediatek CCI frequency device > + > +Required properties: > +- compatible: should contain "mediatek,mt8183-cci" for cci devfreq > + > +- clocks: for cci devfreq > + > +- clock-names: for cci devfreq driver to reference > + > +- operating-points-v2: for cci devfreq opp table > + > +Example: > + cci: cci { > + compatible = "mediatek,cci"; > + clocks = <&apmixedsys CLK_APMIXED_CCIPLL>; > + clock-names = "cci_clock"; > + operating-points-v2 = <&cci_opp>; > + }; > + > -- Best Regards, Chanwoo Choi Samsung Electronics