Hi Laurent, On 03/04/14 01:16, Laurent Pinchart wrote: >>> @@ -534,6 +569,7 @@ static struct platform_driver vsp1_platform_driver = { >>> > > .owner = THIS_MODULE, >>> > > .name = "vsp1", >>> > > .pm = &vsp1_pm_ops, >>> > > + .of_match_table = of_match_ptr(vsp1_of_match), >> > >> > Is of_match_ptr() really useful here, when vsp1_of_match[] array is always >> > compiled in ? > > Would it be better to compile the vsp1_of_match[] array conditionally ? On the > other hand the driver is only useful (at least at the moment) on ARM Renesas > SoCs, which are transitioning to DT anyway. Given that #ifdefs could be soon removed anyway (when the platform becomes dt-only) I guess it's better not to introduce it now. -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html