Am Donnerstag, den 03.04.2014, 10:21 +0200 schrieb Lucas Stach:
> Hi Shawn,
>
> Am Donnerstag, den 03.04.2014, 14:50 +0800 schrieb Shawn Guo:
> > On Fri, Mar 28, 2014 at 05:52:55PM +0100, Lucas Stach wrote:
> > > As defined in the new binding.
> > >
> > > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> > > ---
> > > drivers/pci/host/pci-imx6.c | 74 ++++++++++++++++++---------------------------
> > > 1 file changed, 29 insertions(+), 45 deletions(-)
> > >
> > > diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> > > index ee082509b0ba..71730bbcd9a2 100644
> > > --- a/drivers/pci/host/pci-imx6.c
> > > +++ b/drivers/pci/host/pci-imx6.c
> > ...
> > > @@ -583,32 +574,25 @@ static int __init imx6_pcie_probe(struct platform_device *pdev)
> > > }
> > >
> > > /* Fetch clocks */
> > > - imx6_pcie->lvds_gate = devm_clk_get(&pdev->dev, "lvds_gate");
> > > - if (IS_ERR(imx6_pcie->lvds_gate)) {
> > > - dev_err(&pdev->dev,
> > > - "lvds_gate clock select missing or invalid\n");
> > > - return PTR_ERR(imx6_pcie->lvds_gate);
> > > - }
> > > -
> > > - imx6_pcie->sata_ref_100m = devm_clk_get(&pdev->dev, "sata_ref_100m");
> > > - if (IS_ERR(imx6_pcie->sata_ref_100m)) {
> > > + imx6_pcie->pcie_phy = devm_clk_get(&pdev->dev, "pcie_phy");
> > > + if (IS_ERR(imx6_pcie->pcie_phy)) {
> >
> > Won't this break the existing DTBs?
> >
> Yes, it will. But I think it's justified to break the binding,
> considering how much brokenness was in there and the relatively few
> number of users right now.
>
> All these patches depend on agreement of the new binding, as laid out in
> patch 2/8. I don't think it makes much sense in keeping the old cruft
> around given that the old binding was properly reviewed by PCI experts.
^ wasn't (obviously)
>
> Regards,
> Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
