On 11.04.19 18:57, Guenter Roeck wrote: > On Thu, Apr 11, 2019 at 03:30:11PM +0200, Stefan Wahren wrote: >> >> -ATTRIBUTE_GROUPS(pwm_fan); >> +static umode_t pwm_fan_attrs_visible(struct kobject *kobj, struct attribute *a, >> + int n) >> +{ >> + struct device *dev = container_of(kobj, struct device, kobj); >> + struct pwm_fan_ctx *ctx = dev_get_drvdata(dev); >> + struct device_attribute *devattr; >> + >> + /* Hide fan_input in case no interrupt is available */ >> + devattr = container_of(a, struct device_attribute, attr); > Field day for static analyzers - devattr is no longer used. > No need to resend. I'll let the series rest for a couple of days > and then apply to hwmon-next (after removing devattr) unless there are > additional comments. > Thank you Stefan