On Wed, Apr 10, 2019 at 09:20:29AM +0300, Daniel Baluta wrote: > Hi Nicolin, > > On Wed, Apr 10, 2019 at 7:30 AM Nicolin Chen <nicoleotsuka@xxxxxxxxx> wrote: > > > > On Tue, Apr 09, 2019 at 11:27:39AM +0000, Viorel Suman wrote: > > > Use "of_device_id.data" to specify the machine driver > > > instead of "model" DTS attribute. > > > > > > Signed-off-by: Viorel Suman <viorel.suman@xxxxxxx> > > > > Acked-by: Nicolin Chen <nicoleotsuka@xxxxxxxxx> > > > > > --- > > > sound/soc/fsl/fsl_audmix.c | 43 +++++++++++++++++++++++-------------------- > > > 1 file changed, 23 insertions(+), 20 deletions(-) > > > > > + priv->pdev = platform_device_register_data(&pdev->dev, mdrv, 0, NULL, > > > + 0); > > > > Would you please send a separate patch to replace "pdev->dev"? > > I am not sure exactly how to explain this change in the commit message. It does > make code easier to read and avoids dereferencing pdev pointer each time. > > Is it enough for commit description? You mean this? https://lore.kernel.org/patchwork/patch/862610/
