On Tue, Apr 01, 2014 at 03:19:40PM +0200, Ben Dooks wrote: > On 31/03/14 21:06, Greg KH wrote: > > On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: > >> This function adds a helper function to configure clock parents and rates > >> as specified in clock-parents, clock-rates DT properties for a consumer > >> device and a call to it before driver is bound to a device. > >> > >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > > [snip] > > > > > I don't understand why you need the driver core to initialize this one > > type of thing? That should be in a driver, or in a class, or at worse > > case, the platform code. > > > > What makes clocks so "unique" here? > > I suppose the issue here is that a lot of drivers currently use > clocks and a number of systems have badly setup default clock trees > at start time. > > Mark Brown and others have argued that the management of clocks which > is common to all devices should not live in the driver. Exactly, this data should be part of the clock provider DT nodes, not of the device nodes. Cheers, Peter. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
