Re: [PATCH] arm64: dts: imx8mq: add GPU node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,
On Mon, Apr 08, 2019 at 03:07:29PM +0200, Guido Günther wrote:
> Hi Lucas,
> On Thu, Apr 04, 2019 at 06:52:11PM +0200, Lucas Stach wrote:
> > This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.
> > 
> > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 4300781558f6..79d418b4f585 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -792,6 +792,28 @@
> >  			};
> >  		};
> >  
> > +		gpu: gpu@38000000 {
> > +			compatible = "vivante,gc";
> > +			reg = <0x38000000 0x40000>;
> > +			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&clk IMX8MQ_CLK_GPU_ROOT>,
> > +			         <&clk IMX8MQ_CLK_GPU_SHADER_DIV>,
> > +			         <&clk IMX8MQ_CLK_GPU_AXI>,
> > +			         <&clk IMX8MQ_CLK_GPU_AHB>;
> > +			clock-names = "core", "shader", "bus", "reg";
> > +			assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> > +			                  <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> > +			                  <&clk IMX8MQ_CLK_GPU_AXI>,
> > +			                  <&clk IMX8MQ_CLK_GPU_AHB>;
> > +			assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
> > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > +			                         <&clk IMX8MQ_GPU_PLL_OUT>;
> > +			assigned-clock-rates = <800000000>, <800000000>,
> > +			                       <800000000>, <800000000>;
> > +			power-domains = <&pgc_gpu>;
> > +		};
> 
> Reviewed-by: Guido Günther <agx@xxxxxxxxxxx>

On a second thought should this have a

    status = "disabled";

Cheers,
 -- Guido


> 
> Cheers,
>  -- Guido
> 
> 
> > +
> >  		usb_dwc3_0: usb@38100000 {
> >  			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> >  			reg = <0x38100000 0x10000>;
> > -- 
> > 2.20.1
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> > 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux