Hi Alan, Thanks for look into it and providing the ACK. I got one minor comments from Moritz Fischer do you want me fix that issue now or I can fix it later as it’s a minor comment? In which kernel version i can expect this driver changes?? Regards, Navakishore. > -----Original Message----- > From: Alan Tull [mailto:atull@xxxxxxxxxx] > Sent: Tuesday, April 2, 2019 11:57 PM > To: Nava kishore Manne <navam@xxxxxxxxxx> > Cc: Moritz Fischer <mdf@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Mark > Rutland <mark.rutland@xxxxxxx>; Michal Simek <michals@xxxxxxxxxx>; Rajan > Vaja <RAJANV@xxxxxxxxxx>; Jolly Shah <JOLLYS@xxxxxxxxxx>; linux- > fpga@xxxxxxxxxxxxxxx; open list:OPEN FIRMWARE AND FLATTENED DEVICE > TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; moderated list:ARM/FREESCALE > IMX / MXC ARM ARCHITECTURE <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; linux- > kernel <linux-kernel@xxxxxxxxxxxxxxx>; kishore m > <chinnikishore369@xxxxxxxxx> > Subject: Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for > Xilinx zynqmp > > On Tue, Apr 2, 2019 at 7:32 AM Nava kishore Manne <nava.manne@xxxxxxxxxx> > wrote: > > Hi Nava, > > Looks good. > > > > > This patch adds FPGA Manager support for the Xilinx ZynqMP chip. > > > > Signed-off-by: Nava kishore Manne <nava.manne@xxxxxxxxxx> > Acked-by: Alan Tull <atull@xxxxxxxxxx> > > > --- > > Changes for v4: > > -Updated the Fpga Mgr registrations call's > > to 5.0 > > -Removed dma_set_mask_and_coherent() As the FW > > supports only 32-bit address operations. > > > > Changes for v3: > > -Created patches on top of 5.0-rc5. > > No functional changes. > > > > Changes for v2: > > -Fixed some minor coding issues as suggested by > > Moritz > > > > Changes for v1: > > -None. > > > > Changes for RFC-V2: > > -Updated the Fpga Mgr registrations call's > > to 4.18 > > Thanks, > Alan