Hello! Le 04/08/2019 02:05 PM, Linus Walleij a écrit : > On Wed, Apr 3, 2019 at 3:41 PM Pascal PAILLET-LME <p.paillet@xxxxxx> wrote: > >> This patch adds stpmic1 support on stm32mp157c ed1 board. >> The STPMIC1 is a PMIC from STMicroelectronics. The STPMIC1 integrates 10 >> regulators, 3 power switches, a watchdog and an input for a power on key. >> >> Signed-off-by: Pascal Paillet <p.paillet@xxxxxx> > OK > >> + /delete-property/dmas; >> + /delete-property/dma-names; > Maybe you can add a comment both to the commit message and the > DTS file as to why you are doing this? > > I hope you are not trying to work around a bug in the driver by > stripping out DMA configuration from the device tree, because then > it is probably a better idea to fix the bug. This is not a workaround. The PMIC can use the DMA over I2C bus. Our goal is to avoid using a DMA channel for a consumer that generates a very few traffic. Dma channels may lack for other use cases. If you agree, you can add the to the commit message. > Yours, > Linus Walleij > thank you, Best Regards, Pascal
