Hi Rob, Suzuki, On Sat, Apr 06, 2019 at 07:21:44PM +0800, Leo Yan wrote: > Following the same fashion with replicator DT binding, this patch is to > unify the DT binding for funnel to support static and dynamic modes; > finally we get the funnel DT binding as below: > > Before patch: > > Static funnel, aka. non-configurable funnel: > Not supported; > > Dynamic funnel, aka. configurable funnel: > "arm,coresight-funnel", "arm,primecell"; > > After patch: > > Static funnel: > "arm,coresight-static-funnel"; > > Dynamic funnel: > "arm,coresight-funnel", "arm,primecell"; (obsolete) > "arm,coresight-dynamic-funnel", "arm,primecell"; > > At the end of this patch, it gives an example for static funnel DT > binding, and updates the dynamic funnel example. > > Cc: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx> > Cc: Suzuki K Poulose <suzuki.poulose@xxxxxxx> > Cc: Wanglai Shi <shiwanglai@xxxxxxxxxxxxx> > Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx> Though you gave the reviewing tag for patch v3, but in v4 I added a new compatible string "arm,coresight-dynamic-funnel" and mark "arm,coresight-funnel" as obsolete; and also changed the commit log. For this reason I didn't add your tags in this patch, so please review again. Thanks!