On 4/5/19 08:53, Krzysztof Kozlowski wrote: > On Thu, 4 Apr 2019 at 19:22, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote: >> From: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> >> >> Exynos SoCs have Chipid, for identification of product IDs and SoC >> revisions. This patch intends to provide initialization code for all >> these functionalities, at the same time it provides some sysfs entries >> for accessing these information to user-space. >> Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> >> [m.szyprowski: for suggestion and code snippet of product_id_to_soc_id] >> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> >> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> > > Toy need to add your SoB here. Will correct that in next iteration. >> diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c >> new file mode 100644 >> index 000000000000..5cb018807817 >> --- /dev/null >> +++ b/drivers/soc/samsung/exynos-chipid.c >> @@ -0,0 +1,111 @@ >> +#include <linux/io.h> >> +#include <linux/of.h> >> +#include <linux/of_address.h> >> +#include <linux/of_platform.h> >> +#include <linux/platform_device.h> > > I commented Bartlomiej's patch which you included here. I did not > receive any further feedback from him so I do not know whether he > agrees with my comments or not... but if you send the same patch again > without addressing these comments, I feel like ignored. > > I stopped on first ignored comment. > > Therefore please address be sure that you addressed my comments from > Bartlomiej's patchset. If you do not agree with them, please let me > know. The comments are here: > https://patchwork.kernel.org/project/linux-samsung-soc/list/?series=43565&state=* I will drop that unneeded header inclusion in next iteration. It was just my oversight, I somehow missed your previous comments. And of course your reviews are appreciated. -- Regards, Sylwester
