Hi Pavel, On 4/4/19 3:21 PM, Pavel Machek wrote:
Hi! I have not yet gone through the series in great detail. This will change the userland ABI, right? Now, I understand that old ABI is bad, but will it break someone's code?
It will not break anyone since the generic support for composing LED names is used only if struct init_data is provided. Otherwise led_cdev->name property is taken as is for the LED class device name. Moreover, it is safe to switch many of existing DT (or fwnode in general) based drivers to using generic mechanism. If the DT provides label property it will be concatenated with the led_hw_name provided by the driver. The problem would be only with the drivers whose bindings erroneously require devicename section in the label. They will need to be left intact. -- Best regards, Jacek Anaszewski
