Hi Andrey,
This looks good. Only some minor comments:
On Wed, Mar 27, 2019 at 3:41 AM Andrey Smirnov <andrew.smirnov@xxxxxxxxx> wrote:
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx7d-zii-rpu2.dts
> @@ -0,0 +1,936 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +
Shawn mentioned on a prior submission of mine that this empty line is
not needed.
> + cs2000_ref: cs2000-ref {
generic node name, please.
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <24576000>;
> + };
> +
> + cs2000_in_dummy: cs2000-in-dummy {
generic node name, please.
> +&ecspi1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ecspi1>;
> + status = "okay";
> +
> + cs-gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
status property usually is the last one. So please move cs-gpios prior
to status.
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + spi-max-frequency = <20000000>;
> + reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + };
> +};
> +
> +&i2c1 {
> + clock-frequency = <100000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c1>;
> + status = "okay";
> +
> + pmic: pfuze3000@8 {
pmic@8
Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>
