Hi Joel > index 000000000000..fb56e425bd48 > --- /dev/null > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h > @@ -0,0 +1,104 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +// Copyright 2018 IBM Corporation > + > +#include <drm/drmP.h> > +#include <drm/drm_simple_kms_helper.h> A drmP.h include was left here, can we have this removed too. > + > +static struct drm_driver aspeed_gfx_driver = { > + .driver_features = DRIVER_GEM | DRIVER_MODESET | > + DRIVER_PRIME | DRIVER_ATOMIC | > + DRIVER_HAVE_IRQ, DRIVER_HAVE_IRQ is obsolete and not needed anymore. See drm_drv.h for details. With these few things fixed: Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>