On Mon, Apr 01, 2019 at 11:48:47PM +0200, Pavel Machek wrote:
> So ... we can have multiple LEDs, each can have up to two
> sources.. and the settings are really per source, not per LED.
>
> But you do not test for overlaps. What prevents me from having
>
> foo {
> led_sources = <0>;
> ti,linear-mapping-mode;
> }
> bar {
> led_sources = <0>;
> }
>
> (I.e. conflicting settings for a source?)
In this case, it will go with the settings for 'bar'. I didn't check for
the conflicting settings since I was going for consistency with the
other two backlight drivers that already have the led-sources property:
arcxcnn_bl.c and sky81452-backlight.c. I can add the additional check
to fail if a source has already been encountered.
> Plus I do not see parsing of led labels etc...
OK... I can fix that up plus your other two comments.
Thanks,
Brian
