Re: [PATCH v8 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 29, 2019 at 6:38 AM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Thu, Mar 28, 2019 at 12:03 PM Patrick Venture <venture@xxxxxxxxxx> wrote:
> >
> > On Thu, Mar 28, 2019 at 9:50 AM Rob Herring <robh@xxxxxxxxxx> wrote:
> > >
> > > On Wed, 27 Mar 2019 14:21:55 -0700, Patrick Venture wrote:
> > > > Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings.
> > > >
> > > > Signed-off-by: Patrick Venture <venture@xxxxxxxxxx>
> > > > ---
> > > > Changes for v8:
> > > > - None
> > > > Changes for v7:
> > > > - Moved node under the syscon node it requires
> > > > Changes for v6:
> > > > - None
> > > > Changes for v5:
> > > > - None
> > > > Changes for v4:
> > > > - None
> > > > Changes for v3:
> > > > - None
> > > > Changes for v2:
> > > > - Added comment about syscon required parameter.
> > > > ---
> > > >  .../bindings/misc/aspeed-p2a-ctrl.txt         | 48 +++++++++++++++++++
> > > >  1 file changed, 48 insertions(+)
> > > >  create mode 100644 Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt
> > > >
> > >
> > > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > > there's no need to repost patches *only* to add the tags. The upstream
> > > maintainer will do that for acks received on the version they apply.
> > >
> > > If a tag was not added on purpose, please state why and what changed.
> >
> > Adding tags in this case is adding a change version?  I was doing this
> > to keep the two patches version-synced.  I thought that was required.
> > There was a version change in the other patch in this set.
>
> Adding tags is not considered a change. I gave a Reviewed-by in v7.
> Subsequent versions should carry that tag if there's no change (or
> only minor changes) in this patch. What happens in the other patches
> is not really important. Maintainers are not going to go searching
> thru the versions to find all the ack/review tags. And if I've already
> reviewed this, I don't want to look at it again.

Thank you, I didn't realize that had happened.

>
> Rob



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux