Hi, thanks for your comments. I'll address them in v2.
On Fri, Mar 22, 2019 at 09:31:53AM +0800, Shawn Guo wrote:
> On Tue, Mar 19, 2019 at 04:24:17PM +0100, Jonathan Neuschäfer wrote:
> > The Kobo Aura is an e-book reader released in 2013.
[...]
> > + sd2_pwrseq: pwrseq {
> > + compatible = "mmc-pwrseq-simple";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_sd2_reset>;
> > +
>
> Please do not have random newlines.
Does that apply to all empty lines between properties?
>
> > + reset-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
> > + };
> > +
[...]
> > +&iomuxc {
> > + pinctrl_uart2: uart2 {
> > + fsl,pins = <
> > + MX50_PAD_UART2_TXD__UART2_TXD_MUX 0x1e4
> > + MX50_PAD_UART2_RXD__UART2_RXD_MUX 0x1e4
> > + >;
> > + };
> > +
> > + pinctrl_i2c1: i2c1 {
>
> Please sort these pinctrl nodes alphabetically.
It doesn't make a difference here, but should I generally sort by name
or by label in cases like this one?
Jonathan Neuschäfer
Attachment:
signature.asc
Description: PGP signature
