Re: [PATCH 4/6] arm64: dts: qcom: qcs404: Enable blsp1_uart3 for qcs404-evb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun 24 Mar 09:32 PDT 2019, Vinod Koul wrote:

> From: Shawn Guo <shawn.guo@xxxxxxxxxx>
> 
> It defines pinctrl settings for blsp1_uart3 in board level dts and
> enable the device by toggling 'status'.
> 
> Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> Signed-off-by: Abhinav Asati <asatiabhi@xxxxxxxxxxxxxx>
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>

How about a review of this patch instead?

https://lore.kernel.org/lkml/20190305070823.11845-1-bjorn.andersson@xxxxxxxxxx/

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> index 323f9633084b..d4fadeaa0bbc 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> @@ -7,6 +7,7 @@
>  / {
>  	aliases {
>  		serial0 = &blsp1_uart2;
> +		serial1 = &blsp1_uart3;
>  	};
>  
>  	chosen {
> @@ -137,6 +138,11 @@
>  };
>  
>  &tlmm {
> +	blsp1_uart3_default: blsp1-uart3-default {
> +		drive-strength = <2>;
> +		bias-disable;
> +	};
> +
>  	sdc1_on: sdc1-on {
>  		clk {
>  			pins = "sdc1_clk";
> @@ -205,3 +211,7 @@
>  		bias-disable;
>  	};
>  };
> +
> +&blsp1_uart3 {
> +	status = "okay";
> +};
> -- 
> 2.20.1
> 



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux