Re: [RESEND PATCH v6 09/11] leds: max77650: add LEDs support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/22/19 10:53 AM, Bartosz Golaszewski wrote:
pt., 22 mar 2019 o 10:21 Pavel Machek <pavel@xxxxxx> napisał(a):

On Mon 2019-03-18 18:42:26, Bartosz Golaszewski wrote:
From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>

This adds basic support for LEDs for the max77650 PMIC. The device has
three current sinks for driving LEDs.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
Acked-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>

Acked-by: Pavel Machek <pavel@xxxxxx>

+             label = of_get_property(child, "label", NULL);
+             if (!label) {
+                     led->cdev.name = "max77650::";
+             } else {
+                     led->cdev.name = devm_kasprintf(dev, GFP_KERNEL,
+                                                     "max77650:%s", label);
+                     if (!led->cdev.name)
+                             return -ENOMEM;
+             }

I'd rather not have the "max77650:" prefix in the LED name (as it is
useless).


I was instructed to do so by the LED subsystem maintainer.

Yes, let's keep things consistent, we will convert it to use generic
support for LED naming once that support is merged.

--
Best regards,
Jacek Anaszewski



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux