On Wed, 20 Mar 2019, Jacek Anaszewski wrote: > Hi Dan, > > I have one minor issue below. > > On 3/13/19 1:32 PM, Dan Murphy wrote: > > Introduce the Texas Instruments LM3532 White LED driver. > > The driver supports ALS configurability or manual brightness > > control. > > > > The driver also supports associating LED strings with specific > > control banks in a group or as individually controlled strings. > > > > Signed-off-by: Dan Murphy <dmurphy@xxxxxx> > > --- > > > > v4 - Updated code to DT doc changes appending "ti," to TI specific properties - > > https://lore.kernel.org/patchwork/patch/1050124/ > > > > v3 - Removed switch case for register setting in favor of an algorithim (v1 comment), > > https://lore.kernel.org/patchwork/patch/1049024/ > > v2 - Added look up tables for als_avg, als_imp and ramp times, fixed brightness > > control when ALS is in control, added property value checks to ensure the values > > are not out of bounds - https://lore.kernel.org/patchwork/patch/1048807/ > > > > drivers/leds/Kconfig | 10 + > > drivers/leds/Makefile | 1 + > > drivers/leds/leds-lm3532.c | 681 +++++++++++++++++++++++++++++++++++++ > > 3 files changed, 692 insertions(+) > > create mode 100644 drivers/leds/leds-lm3532.c [snip] > > diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c > > new file mode 100644 > > index 000000000000..e8a614d71469 > > --- /dev/null > > +++ b/drivers/leds/leds-lm3532.c [snip 700 lines of churn] Jacek could you please trim your replies please? It took way to long to locate your one line comment in this 700 line patch. > > +static int lm3532_remove(struct i2c_client *client) > > +{ > > + struct lm3532_data *drvdata = i2c_get_clientdata(client); > mutex_destroy(&drvdata->lock); -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
