On Tue, Mar 19, 2019 at 9:55 AM Samuel Holland <samuel@xxxxxxxxxxxx> wrote: > > On 03/18/19 02:33, Chen-Yu Tsai wrote: > > From: Chen-Yu Tsai <wens@xxxxxxxx> > > > > The device tree binding already lists compatible strings for these two > > SoCs. Add a device node for them. > > > > Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx> > > --- > > arch/arm/boot/dts/sun8i-h3.dtsi | 4 ++++ > > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 5 +++++ > > arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 4 ++++ > > 3 files changed, 13 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi > > index 959d265e7254..e37c30e811d3 100644 > > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > > @@ -231,3 +231,7 @@ > > &rtc { > > compatible = "allwinner,sun8i-h3-rtc"; > > }; > > + > > +&sid { > > + compatible = "allwinner,sun8i-h3-sid"; > > +}; > > diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi > > index d74a6cbbfdf4..e2100b673a51 100644 > > --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi > > +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi > > @@ -227,6 +227,11 @@ > > #size-cells = <0>; > > }; > > > > + sid: eeprom@1c14000 { > > + /* compatible and clocks are in per SoC .dtsi file */ > > There are no clocks for this node, just a compatible string. Right. I'll fix this when applying. ChenYu