Re: [PATCH] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Στις Πεμ, 14 Μαρ, 2019 at 9:02 ΜΜ, ο/η Heiko =?iso-8859-1?q?St=FCbner?= <heiko@xxxxxxxxx> έγραψε:
Hi,

Am Donnerstag, 14. März 2019, 19:20:35 CET schrieb Leonidas P. Papadakos:
 From: William Wu <william.wu@xxxxxxxxxxxxxx>

 RK3328 has one USB 3.0 OTG controller which uses DWC_USB3
 core's general architecture. It can act as static xHCI host
 controller, static device controller, USB 3.0/2.0 OTG basing
 on ID of USB3.0 PHY.

 Signed-off-by: William Wu <william.wu@xxxxxxxxxxxxxx>
 Signed-off-by: Leonidas P. Papadakos <papadakospan@xxxxxxxxx>

the rk3328 usb3-phy has an issue with detecting any plugin events
after a previous device got removed - see the inno-usb3-phy driver
in the vendor kernel.

So once you unplug an usb device from the port it won't detect
a newly connected device. This is also the reason why the original
usb3 patches are still sitting around in my tree, as I don't want to
codify a binding that may not last once somebody actually manages
to go around that issue with kernel code - especially as the node
below claims to be compatible with the rk3399 dwc3.


Heiko

 ---
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 27 ++++++++++++++++++++++++
  1 file changed, 27 insertions(+)

 diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
b/arch/arm64/boot/dts/rockchip/rk3328.dtsi index 84f14b132..f5c1ab596
 100644
 --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
 +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
 @@ -917,6 +917,33 @@
  		status = "disabled";
  	};

 +	usbdrd3: usb@ff600000 {
 +		compatible = "rockchip,rk3328-dwc3", "rockchip,rk3399-dwc3";
 +		clocks = <&cru SCLK_USB3OTG_REF>, <&cru SCLK_USB3OTG_SUSPEND>,
 +			 <&cru ACLK_USB3OTG>;
 +		clock-names = "ref_clk", "suspend_clk",
 +			      "bus_clk";
 +		#address-cells = <2>;
 +		#size-cells = <2>;
 +		ranges;
 +		status = "disabled";
 +
 +		usbdrd_dwc3: dwc3@ff600000 {
 +			compatible = "snps,dwc3";
 +			reg = <0x0 0xff600000 0x0 0x100000>;
 +			interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
 +			dr_mode = "otg";
 +			phy_type = "utmi_wide";
 +			snps,dis_enblslpm_quirk;
 +			snps,dis-u2-freeclk-exists-quirk;
 +			snps,dis_u2_susphy_quirk;
 +			snps,dis_u3_susphy_quirk;
 +			snps,dis-del-phy-power-chg-quirk;
 +			snps,dis-tx-ipgap-linecheck-quirk;
 +			status = "disabled";
 +		};
 +	};
 +
  	gic: interrupt-controller@ff811000 {
  		compatible = "arm,gic-400";
  		#interrupt-cells = <3>;




Now it makes sense. I thought it was board specific. It's a general rk3328 issue, then.
Thanks for clearing it up. (yet again, oops)






[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux